P. L. Lim comments

Results 1965 comments of


                                            P. L. Lim

BUG: Fix wrong Subset unit when created in 2D spectrum viewer

Thanks, all!

bkg_spectrum to take func instead of string

Where is the `statistic`? I was looking at `Spectrum1D.collapse` upstream which takes function.

bkg_spectrum to take func instead of string

Hmm... Should #253 have used this `statistic` instead of introducing a new keyword?

bkg_spectrum to take func instead of string

@tepickering , I think I have addressed your comment. But now though, this is a breaking change. Not sure if it belongs in bugfix anymore... 😬

bkg_spectrum to take func instead of string

New PR is fine. I can close this one. Thanks for taking this over!

[BUG] TypeError when fitting a model to MaNGA Cubes

What is the cube data unit? It is triggered here but somehow `solid_angle_in_targ` is `None`. https://github.com/spacetelescope/jdaviz/blob/527d1f5e0e5ecff9585957ed153bd28963a51e51/jdaviz/utils.py#L512

[BUG] TypeError when fitting a model to MaNGA Cubes

> which should catch this case L507 acknowledges that `solid_angle_in_targ` could be `None` but still tries to stuff it into a unit on L512, which does not make sense to...

update unit conversion message responses in plugins, add tests

Is a regression test easy to add? Both you and Ricky seemed surprised that CI didn't catch this.

Making docs index match better with github 'About' description

"Built for the James Webb Space Telescope" might throw some people off, especially if they don't bother reading the rest of the sentence.

Making docs index match better with github 'About' description

Hmm why was this not merged?