Nabil Freij

Results 791 comments of Nabil Freij

**NOTE TO WHOEVER MERGES THIS, SQUASH MERGE**

> > The question came, do we want to do this in the Map source? > > Which HMI files need this fix? That is a good question, I will...

I asked and I was told that the original expectation was that people would access this via the web. So I think a client would be ok.

Without more context, it is hard for me to know if that is a good thing to change. Can you open the PR with the hotfix and we can go...

Can you also submit the client, on the surface at least the VSOClient seem to be ok with the current attr code. So I think it is worth working out...

I will close this in favour of the PR that adds the client.

Thanks for opening the issue @JonasSinjan. On the surface I am reluctant to provide a keyword for a magnetogram with any specific settings. I don't think that sunpy should be...

There was a discussion around this tool at the Scientific Python summit and its great but due to some false positives, people suggested it would be better to run it...

I think based on Laura's comment, I don't think we need a new reader for this file type. Maybe an example or a page somewhere in our docs might be...