Nabil Freij

Results 767 comments of Nabil Freij

> as was already said above: this is not an actual fix, because now you can not use `pre-commit autoupdate` any longer, as > > > But `pre-commit autoupdate` will...

Thanks for the PR @Sauravroy34, I think a few unit tests to check it works would be the next stage.

You will need to add a test loading and saving an asdf file with a map directly.

> I think there are some improvements needed before this can address the issue. Adding the test requested in [#7712 (comment)](https://github.com/sunpy/sunpy/pull/7712#issuecomment-2237102845) should show what's required. I believe [detect_filetype](https://github.com/sunpy/sunpy/blob/e5878584d57ed21916b390987cfe7d641387540c/sunpy/io/_file_tools.py#L179) will need...

Hi @Sauravroy34, before you continue to work on this PR. A discussion about the approach and how sunpy handles the downloading, the storage and use of these files needs to...

> > Hi @Sauravroy34, before you continue to work on this PR. A discussion about the approach and how sunpy handles the downloading, the storage and use of these files...

> I have a doubt on how can I enocde kerenls type generally What doubts?

No clue, something hopefully collectively we can work out on the issue.