Nabil Freij
Nabil Freij
Hi @wmoapl, I need to review the PR but I have a quick question. From what I understand (from the original issue) is that astropy already supports S3 URIs, we...
Thanks for explaining that for me. I hope to get others to review and discuss this PR during the next sunpy community meeting, so we can go forward with this....
We can add a cdf file to the data repo which will upload it to the S3 bucket, do you have a file in mind?
This file has been added to the data repo. The CI says it has synced the file to S3. The normal URL is: http://data.sunpy.org/sunpy/v1/psp_fld_l2_mag_rtn_1min_20200104_v02.cdf
Thanks for the PR again @wmoapl. I added a whatsnew label but since it covers at least two topics, it might be easier to do that after the PR has...
Failed tests are upstream changes we can worry about in the future.
Thank you very much @wmoapl for opening this PR and sticking with us during the review process.
Yeah my assumption was the 2.0.1 release of numpy as well which we should report upstream?
I will try but I won't get to my windows computer for another 8 hours.
Thanks for the report @bnavigator, would adding those folders to the manifest file also work? I opened a PR making those changes you made instead and removing the manifest file....