Nabil Freij

Results 767 comments of Nabil Freij

> alright so it seems better to not tackle this issue right now Yes, I would look at other issues.

I guess my interpretation of this issue isn't just filtering based on string values.

Why can't you open a pull request without the changes from 7922?

Then in that case, open a new PR with the changes from 7922 and when 7922 is merged, you can rebase the new PR. That's a normal workflow.

Thanks for the PR @ankitkhushwaha. As it stands, this does not really integrate with the release workflow and I think that needs thinking about before we continue with this PR.

> > As it stands, this does not really integrate with the release workflow and I think that needs thinking about before we continue with this PR. > > Are...

Hmm, I think the example needs to be changed instead so it works but at least we should change how the repr works out the time range

> I have tested the code with `pandas.TimeStamp` and `Astropy.Time` everything is working fine just i have to add some unit tests > > Then should i change the example...