Nabil Freij
Nabil Freij
@hayesla does something like this solve your original issue?
Will need some unit tests and a feature changelog entry
The figure hashes need to be updated as well due to the changes.
What was the data you used in that example? We need to consider adding more test data from not-AIA.
This issue was fixed by https://github.com/sunpy/sunkit-image/pull/231 and I forgot to close this PR. In your case, the code example, uses data on the original authors laptop.
@FreyaJain, if you could open a PR and we can discuss changes there.
We could call it fillna
You can run the new tox test environment locally: https://tox.wiki/en/4.23.2/user_guide.html For checking it works on GitHub actions, you can enable github actions on your own fork and test it that...
Yes but the issue is now to create the specific tests required. This is a complex task and I do not recommend anyone who does not understand what is needed...
> What was the actual issue here? Do the cutouts from the JSOC have a different datatype than the full-disk L1 files? I didn't debug the reason.