Nabil Freij
Nabil Freij
The online CI is a constant fight, so I will close this and we will just have to not ignore the bot messages on Element
> ``` > > ...... > ...... > > > > > ........ > ........ > > > > > ``` > > The function returns the dictionary as: >...
Why can't we just append to the string? Or am I missing something?
> @nabobalis, also, the test file provided in the issue #6239 has other elements, too, which are occurring multiple times. What should we do for comments of the elements other...
> @nabobalis that's what we are doing even now, it's just that we are not storing just the text values for all the elements with multiple occurrence so is it...
> @nabobalis we are not removing any value, the values keep getting overwritten in case multiple occurrences are there. So everytime we encounter an element node, we just keep updating...
I asked during the weekly meeting and hopefully others will chime in soon on this. We want to capture all the "key" comments as that information can be very useful....
Then maybe we should mimic the FITS handling for now and then if we need to expand upon that later we can?
So how does the output look like now? We also will need a unit test for this.
Looks fine to me. We will need a unit test and reviews from other people.