Nabil Freij comments

Results 806 comments of


                                            Nabil Freij

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

Thanks for the PR @ViciousEagle03 and @ayshih

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

I decided not to backport this and add a whatsnew as I don't want to break previous behaviour for filenames for the released versions.

`Cache.download()` deletes an expired file before knowing that it can download a new version of the file

That PR was waiting for unit tests to be added. IF you want to help @samish55 finish off the PR, you should contact them first.

Fix sunpy.io to update header info after scaling applied when data is accessed

~~I pushed a unit test thinking I understood what the problem is but turns out I did not.~~ ~~The test passed before and after the code change.~~ ~~@samaloney, what was...

Fix sunpy.io to update header info after scaling applied when data is accessed

I wasn't able to replicate the original issue, so I will close this for now.

Issues with installing sunpy - there's still some confusion

I think this is now fixed upstream and we do not suggest anaconda install. So I will close this. If you think that's not a fix, we can reopen this.

Adding ability to pass `clip_interval` and `vmin/vmax` to MapSequence.plot()

> This is great, though the amount of code we need to repeat both here and in `GenericMap.plot` is worrying. I don't know of a good way to avoid that...

Requesting support for GONG H-alpha Maps

Will need to verify it works on the JP2 files but hopefully.

Integrate Astropy units into the HEK Results table

I think some unit tests to ensure the files are read correctly would be good.

Remove the hard dep on parfive

That base deps failed but the check passed. Will need to fix that.