Nabil Freij comments

Results 792 comments of


                                            Nabil Freij

Add warning when importing map (or other subpackages) if mpl (or others?) are not installed,

Oh I see. I'd have to check the review again as I forgot.

Prevent `Cache.download()` deleting an expired file before knowing that it can download a new version of the file

Thanks for the code. I think ideally we need a unit test to make sure this behavior is working. It is going to be tricky to do as you will...

JSOCClient fetch sometimes returns hmi.sharp_720s_nrt bitmap files in the wrong file name format

Can please provide a query example I can run to try and work out what is going on?

JSOCClient fetch sometimes returns hmi.sharp_720s_nrt bitmap files in the wrong file name format

Works 99% of the time?

JSOCClient fetch sometimes returns hmi.sharp_720s_nrt bitmap files in the wrong file name format

Hmm, running this a few times, I see all of the files following the format as required. If its failing, its possible it's just due to the return from the...

JSOCClient fetch sometimes returns hmi.sharp_720s_nrt bitmap files in the wrong file name format

Hi @cdidigu674. Unfortunately not, I was not able to replicate it and I spoke to the JSOC, so the problem is definitely on our side, sunpy/jsocclient/drms provided an query with...

JSOCClient fetch sometimes returns hmi.sharp_720s_nrt bitmap files in the wrong file name format

I still have been unable to work to the issue here. Having spoke to the JSOC, it would suggest there might be something wrong in the sunpy/DRMS library but still...

Documentation builds are very slow (and caching is not effective)

I have never seen this locally on my Linux machines when using tox or make html.

Documentation builds are very slow (and caching is not effective)

Yeah I am interested, did they do something in a new release?

Documentation builds are very slow (and caching is not effective)

7.2.6 was the version