Nabil Freij comments

Results 805 comments of


                                            Nabil Freij

Change `Fido.fetch()` to raise an error if one or more files failed to download

> > though > > > @ryuusama09 I believe Albert is making the opposite point: that error should be default behaviour, not controlled by a kwarg. > > Oh ,...

Add a new topic guide for the 2024 Eclipse

> Hello, I'd love to work on this if someone isn't already, thanks Hello! This is going to be part of a potential gsoc project and as such, we don't...

Add a new topic guide for the 2024 Eclipse

> Greetings! @nabobalis, Hello @AnonymousCodes911, > 1.What would be some good first issues you would recommend to familiarize with the codebase? There are not really any of those for this...

Add a new topic guide for the 2024 Eclipse

> Hello @nabobalis I am a third year BS-MS (Physics major) student from IISER Bhopal. Astronomy has always been a pivotal part for me joining academia. I am really passionate...

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

Can you also add a changelog please.

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

Actually in line with https://github.com/sunpy/sunpy/issues/7450#issuecomment-1951436626, his point makes a lot of sense. I think we should leave the periods alone.

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

> So should I remove my fix in `net.py` and remove the periods from the list that `slugify()` function replaces? Yes please.

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

I would be in favour of NFKC

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

Online Test failures look to be real. One is a filename difference, and the other seems to be more results returned from the VSOClient?

Fix filename sanitization for downloaded files (do not replace periods, do not change case, and do not leave Unicode characters decomposed)

> Do you have any tasks for me at the moment . Apologies for not being active last week I was occupied with my mid-terms The online tests need updating...