Nabil Freij

icon indicating an email [email protected]

icon company SETI Institute & LMSAL (@LM-SAL) icon location Palo Alto, California, USA icon location Research Scientist in Solar Physics & Software Engineer

Results 803 comments of Nabil Freij

Creating a map from a .fz file causes an error

I think this might be solved by https://github.com/sunpy/sunpy/pull/6693

Creating a map from a .fz file causes an error

I think we fixed this. Can someone check?

Implemented the vector transformation from one frame to another

I have requested for this to be reviewed and we will wait for that.

Implemented the vector transformation from one frame to another

Thanks for the PR @Deus1704 and thanks for the detailed review @ayshih

Warn user when importing submodule without the submodules dependencies

How do we feel about at least a backport to 5.1?

Warn user when importing submodule without the submodules dependencies

> > How do we feel about at least a backport to 5.1? > > I don't think it is particularly bugfixxy but I don't really care if you want...

If data is of uint8, then set plot_settings and norm accordingly

Do we have a unit test for this case?

If data is of uint8, then set plot_settings and norm accordingly

Yes please.

If data is of uint8, then set plot_settings and norm accordingly

Thanks for the PR @enthusiastic2003

Add support for Map to load from a generator

Looks like this change has failed on the CI, this will need debugging. This will need a unit test as well to check that pathlib.glob works.