Nabil Freij

Results 805 comments of Nabil Freij

> > Looks like this change has failed on the CI, this will need debugging. > > This will need a unit test as well to check that pathlib.glob works....

> There are already two unit test cases for string, list, and tuples. Do you want me to add extra on top of that? `lst = ['a', 'b', [], (['c',...

Hello @Jett-Code, sorry for not getting back to you after a long time. WOuld you have some time soon to add a few unit tests for this?

Actually I think that one glob test is enough, I don't know why I asked for more. Could you rebase this and we will get this reviewed!

> Hey, can you help me with failing test cases? You mean the two failing checks? What would you like help with? The gallery one looks like a real failure...

> Hey, can you help me with failing test cases? Looks like it was due to me removing UserList, adding it back fixed it (at least the examples)

The last set of pushes broke the pull request, can you revert it or fix it please?

> > The last set of pushes broke the pull request, can you revert it or fix it please? > > Is it possible to delete the last commit? Do...

The entire commit history is a bit strange right now. Seems to be repeated?

I pushed from an old branch I had locally. Not sure if it was up to date tho.