Mikkel Malmberg comments

Results 101 comments of


                                            Mikkel Malmberg

default_url_options in SessionsController.create

I … 1. Removed the locale file (I don't want to support locales although I would love it if you could add your translation to the readme!) 2. Moved all...

default_url_options in SessionsController.create

To clarify: I want to support locales but I don't want to bundle them as I'd have to keep them up to date for forever going forward

default_url_options in SessionsController.create

Thank you for working on this! ❤️🧡💛💚💙💜

default_url_options in SessionsController.create

Here: https://github.com/mikker/passwordless/wiki/User-submitted-locale-files

NoMethodError: undefined method `session' for nil

These are your system tests? (I see `/integration/` in the path) Can you make sure the right test helper is being included? We want it to be these https://github.com/mikker/passwordless/blob/master/lib/passwordless/test_helpers.rb#L46-L65 however...

NoMethodError: undefined method `session' for nil

Does your project include https://github.com/rails/rails-controller-testing ? Maybe that adds something?

NoMethodError: undefined method `session' for nil

Nice digging 👍 do you have an idea for a fix?

NoMethodError: undefined method `session' for nil

Appreciate it! 😅

Add support for Turbo Native

Well tested PRs welcome.

Embed redirect URL in magic link

Good digging! Yes, I think it would be great to have that included in the readme somewhere. PR welcome 😊