Mikkel Malmberg
Mikkel Malmberg
I like this idea and have wanted to do something similar, however I think we should take the other way around and make the urls like `/users/sign_in/:token?destination_path=/where/you/want/them/to/end/up`. Work on this...
I usually just put `"N/A"` when manually creating them. Don't have any better ideas than something like you already do. Having a few helpers like you suggest would be nice....
Hi @mplewis! Thank you for using passwordless! First off, I see nothing explicitly wrong with your approach, so if it works it works 😊 If you don't want to patch...
Great! Yes, a note would be great. I'm considering whether the project Wiki would be a better place to put it than the Readme? What do you think?
Let's just do the Readme 👍 Thanks!
Something like this... ```ruby # registrations_controller.rb include Passwordless::ControllerHelpers def create user = User.new(email: params[:email]) if user.save pwless_session = build_passwordless_session(user) pwless_session.save! YourOwnRegistrationsMailer.signup(token: pwless_session.token).deliver_now # ... redirect back or whatever end end...
I'm not sure that's right. `save!` calls callbacks: https://guides.rubyonrails.org/active_record_callbacks.html#running-callbacks
For the same reasons as you state, I didn't find it necessary the first time around. But you are totally right – there are plenty of reasons to hash them....
Thanks! Sure, I'd consider adding something like that. I'd want it to be as little code as possible though. Managing _both_ the bundled views _and_ the generated ones are going...
Hi @koenhandekyn! Thanks for the kind words 😊 I like your suggestions. Would definitely want to add something like that if you or someone made a PR. I'm afraid I...