Mikkel Malmberg comments

Results 101 comments of


                                            Mikkel Malmberg

Add `after_session_confirm` hook after session confirmation

Good idea!

Add `after_session_confirm` hook after session confirmation

Responded in PR. Thank you for contributing @wilburhimself !

Constraint for config/routes.rb

Included in #228. Thank you for contributing to Passwordless!

Unknown email sender config

Thank you for contributing this. Is this mainly a security measure (someone's trying to be you) or user experience (you don't have an account, try another address)?

Unknown email sender config

My feeling is that this functionality shouldn't be included. Feel free to reopen if you'd like to argue otherwise 😊 Thank you for the suggestion and for using Passwordless though!

pass token to email subject translation

Thank you for contributing this. Does it complain if you don't include `%{token}` in your subject, like we don't in the default?

Support case-insensitive tokens?

I think this could be an okay addition behind a config flag. Default is current implementation, so something like `config.case_insensitive_tokens = true`. PRs welcome.

Support skipping loading .env file

Yes please

Validation error with ruby 3.4

Please don't tag people like that @vladimirtcats. Those who need it will already get pings.

Random ActiveRecord::RecordNotFound errors

Anything special about your setup or how you use Passwordless?