Mikkel Malmberg comments

Results 101 comments of


                                            Mikkel Malmberg

Always redirect magic link requests back to the sign_in page and render generic flash

Apologies, I didn't realize. I think actually your suggestion to just disable Turbo on our forms is the best and easiest approach. I think the slight downgrade in app speed...

allow for multi-tenancy

I'm not against passing the whole `params` as long as we add checks and fallbacks to not make it a breaking change. PRs welcome 😊

Allow user to type in/copy paste token in same window after requesting?

Included in upcoming 1.0. See #159

Don't isolate namespace

Closed by #146

Passwordless::ControllerHelpers#sign_in with authenticatable (`User') is deprecated warning

The current, non-deprecated way is this: ```ruby def create @user = User.new(user_params) if @user.save sign_in(build_passwordless_session(@user)) #

Multiple mounts are broken

Fixed in upcoming 1.0

View generators

These were added a while back. See https://github.com/mikker/passwordless#providing-your-own-templates

require email presence in SIGN_IN

Please go ahead 😊 PRs welcome

default_url_options in SessionsController.create

I'm not sure where `default_url_options` comes from in this context? Do we not need to define it in the controller so it's overridable? Could you add a test that covers...

default_url_options in SessionsController.create

Thank you for reporting and contributing all this back. I'm away from work this week but I'll get back to you soon!