Mikkel Malmberg comments

Results 101 comments of


                                            Mikkel Malmberg

Update SQL parser to parse all shared tests

One could argue that the token examples are an implementation detail and not strictly a requirement?

Update SQL parser to parse all shared tests

The original Ruby implementation was also very far from living up to the examples. FWIW copying Andrew's Go implementation to Ruby was a fun challenge and the examples really helped....

Signify that a stack trace was truncated

Got it. Depending on what's possible in the other langs (and what we decide to do) Node could just be the exception.

Signify that a stack trace was truncated

Sounds to me like we should go with the simplest option then. Using different value types for different agents are probably both 1. error prone in UI and 2. adds...

Signify that a stack trace was truncated

IMO Node could just ignore the flag.

Rename the span_frames_min_duration property

If we go with both new name and new meaning, we can keep backwards compatibility. I still think it's a decent idea 👍

Alignment of span type/subtype

Completely agree, @SylvainJuge. Good ideas 👍

Mitigate outliers in transaction duration histogram visualization

I like both your suggestions. I think Felix' idea of _zooming in_ on a range sounds like the _natural_ interaction, and users already know it from the response time/rpm graphs.

Ability to specify flash messages upon redirects

I'm not sure they're needed? IMO, if it works it would be pretty self evident. Not completely sure I'm right now so feel free to try and convince me otherwise.

Always redirect magic link requests back to the sign_in page and render generic flash

Sure, thank you for this.