magento-coding-standard

magento-coding-standard copied to clipboard

This issue is automatically created based on existing pull request: magento/magento-coding-standard#347: Update ESLint configuration --------- This has been copied from https://github.com/magento/magento2/pull/32343 This fixes https://github.com/magento/magento2/issues/32375 The ESLint configuration currently in use...

m2-assistant[bot]

PHP 8.3 error mentioning php 8.1 as version

5

### Preconditions 1.magento/product-enterprise-edition: "2.4.7-p1" 2. magento/magento-coding-standard: "33" 3. Previous coding standard version --> 31 ``` PHP 8.3.9 (cli) (built: Jul 2 2024 14:10:14) (NTS) Copyright (c) The PHP Group Zend...

MaximGns

Fix Class Property DocBlock sniff for union/intersection types

1

Since [PHP_CodeSniffer 3.7.0, there's a separate token `T_TYPE_INTERSECTION` for the `&` type-intersection specifier](https://github.com/PHPCSStandards/PHP_CodeSniffer/commit/c80367101d241b7e4236a718ec96b13b227ad45c#diff-e454877e2ec518b7f88114961cfe972b091affd00d65b31ff01ee7d5dda7cdf8R1472), instead of using the same `T_BITWISE_AND` token for both type intersections and the bitwise operator. Due to...

CRC-Mismatch

[Documentation] Document Object ManagerSniff

2

Describe why the use of Object Manager is considered as a bad practice. ### Acceptance criteria 1. `ObjectManagerSniff.md` file is created. 2. Explanation about why the use of Object Manager...

lenaorobei

Ignore HTML comments

1

### Preconditions 1. Have a file test.html like this: ``` ``` ### Steps to reproduce 1. Run `vendor/bin/phpcs -s --standard=Magento2 test.html` ### Expected result 1. Show no errors. ### Actual...

minsc78

Question on how are this coding standards used in the Quality Reports of Adobe Commerce Marketplace

1

### Description This is more of a question. I found this repository through the link to a Magento extension for passed Coding Standards. My particular concern is the filesystem. I...

madalinignisca

Fixes #33 The current `composer.json` file requires version 3.6.1 or better of PHP_CodeSniffer. That version and versions up to 3.7.2 only check that there is a declaration, but not if...

fredden

Resolve issues with regex include and exclude patterns in Magento 2 ruleset.xml

1

See https://github.com/magento/magento-coding-standard/issues/485 for a detailed description of the issue. These fixes makes the following assumptions and these will need to be verified by someone who knows why the rules were...

gwharton

Update supported PHP versions to match Magento

1

Version 2.4.7-p2 (which is the latest at time of writing) supports PHP versions 8.1.x and 8.2.x and 8.3.x. This change updates the PHPCompatibility configuration to scan for these versions. https://github.com/magento/magento2/blob/2.4.7-p2/composer.json#L21...

fredden

Several include-path regex issues on both Windows and Linux

5

### Preconditions 1. Latest Magento Coding Standards Package. Reproduced on version 33. ### Steps to reproduce The following creates a blank project, installs the necessary composer packages, creates some test...

gwharton