magento-coding-standard

magento-coding-standard copied to clipboard

PHPCompatibility should check for PHP 8.3 and 8.4 compatibility

4

### Description We currently only check for PHP 8.1 and 8.2 compatibility, which is pretty outdated. Especially now that Magento 2.4.8 will be released soon and will only support PHP...

hostep

Escaping for XML is caught by DiscouragedFunctionSniff

1

### Description The following code ` htmlspecialchars($string, ENT_XML1, "UTF-8")` triggers the warning ``` 38 | WARNING | The use of function htmlspecialchars() is discouraged; use | | \Magento\Framework\Escaper->escapeHtml() instead |...

fooman

`'proc_open' => null,` is already defined in the same array on line 38, it makes no sense to keep both around. Found with phpstan (while running it from inside magento...

hostep

Add support for Rector 2.x

1

Fixes #493

fooman

Please add support for Rector 2.x

2

Since the magento-coding-standard uses Rector 1.x which in turn requires Phpstan 1.x it is currently not possible to use the latest versions of those tools in conjunction with this package....

fooman

Please make copyright header check better

1

### Description The new requirements for the copyright header as of a few months are: ``` /** * Copyright [first year code created] Adobe * All rights reserved. */ ```...

hostep

Stricter Escape Checks

2

### Description Currently, there is no validation to ensure that the correct escaping methods are used in the right context. This allows incorrect or inconsistent escaping, leading to potential security...

Morgy93

Remove PHP `assert()` function from list of forbidden functions

1

### Description AFAIK starting from PHP 8.0 the main security issue of `assert()` function implementation is removed. Thus given the minimum PHP requirement version for the Coding Standards is 8.1...

oleksii-lisovyi