magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

Ignore HTML comments

Open minsc78 opened this issue 1 year ago • 1 comments
trafficstars

Preconditions

  1. Have a file test.html like this:
<!-- Comment <http://site.com/path/> -->

Steps to reproduce

  1. Run vendor/bin/phpcs -s --standard=Magento2 test.html

Expected result

  1. Show no errors.

Actual result

  1. Getting this output:
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 1 | ERROR | Avoid using self-closing tag with non-void html element - "<http://site.com/path/>
   |       |  (Magento2.Html.HtmlSelfClosingTags.HtmlSelfClosingNonVoidTag)
------------------------------------------------------------------------------------------------

minsc78 avatar Jul 13 '24 11:07 minsc78

Hi @minsc78. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jul 13 '24 11:07 m2-assistant[bot]