magento-coding-standard

magento-coding-standard copied to clipboard

RestrictedCodeSniff suggests Laminas\Filter\FilterInterface, which is not required by Magento 2.4.5-p1 anymore

7

### Preconditions 1. Magento 2.4.5-p1 2. Magento Coding Standard, 26 ### Steps to reproduce 1. Create a file, where you include `\Zend_Filter_Interface` in the constructor 2. Run `vendor/bin/phpcs --standard=dev/tests/static/framework/Magento` on...

norgeindian

Allow multiline css declarations in less files for increased readability

1

### Preconditions 1. Have a file `test1.less` like this: ```less & when (@media-common = true) { .lib-icon-font( @icon-camera__content, @_icon-font: @icons-admin__font-name, @_icon-font-size: @image-gallery-placeholder-icon__size, @_icon-font-color: @image-gallery-placeholder-icon__color, @_icon-font-text-hide: true ); } ``` 2....

hostep

Warnings on well formatted GraphQL files

2

### Preconditions The bug is reproducible in custom Magento modules that have schema.graphqls files written in readable manner, so e.g. with new line breaks or indentation. A rule that those...

p-makowski

Enforce import of global functions or using FQN calls

1

### Rule ### Reason I used code example from here https://tideways.com/profiler/blog/compiler-optimized-php-functions https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/ If we import or use FQN call for the global function php produces more optimized code. Also visible...

ilnytskyi

DiscouragedFunctionUnitTest.inc Security Flag

5

I've noticed recently that the file DiscouragedFunctionUnitTest.inc file is being flagged by Maldetect scan on Linux. malware hit {CAV}Php.Backdoor.Generic-10006641-0 found for /vendor/magento/magento-coding-standard/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc maldet(7084): {hit} malware hit {CAV}Php.Backdoor.Generic-10006641-0 found for /.cache/composer/files/magento/magento-coding-standard/5cf0da126fda162c53eba8037babc7efd1dae3a9.zip...

drinkingsouls

fredden

Less validate check seem incorrectly as expected

1

### Preconditions 1. Any version magento 2 (Example 2.4.6+) 2. When i checked docs related Sort all properties in the alphabetical order. Mixins, variables, and so on should go first....

mrtuvn

fredden

fredden

Allow use of LESS variables in "class name"

3

Fixes https://github.com/magento/magento-coding-standard/issues/434

fredden