magento-coding-standard

magento-coding-standard copied to clipboard

[New Rule] Add declare(strict_types=1) to your PHP files

11

### Rule All new PHP files MUST have strict type mode enabled by starting with `declare(strict_types=1)`;. All updated PHP files SHOULD have strict type mode enabled. PHP interfaces SHOULD NOT...

lenaorobei

Uncaught Error: Class 'GraphQL\Language\Token' not found in /usr/share/php/PHP/CodeSniffer/src/Files/File.php:556

2

### Steps to reproduce 1. Install phpcs 2. Configure Magento2 coding standard 3. run any module which contains graphql ### Expected result 1.It should run the command and shows the...

darshanperpule

Do not recommend using static:: for private constants

1

### Rule Using `static::` for private constants and methods discouraged. ### Reason In case if someone will extend the class OR create plugin for it - he will get the...

ihor-sviziev

Do not allow slash the beginning of the class pass in use

7

use section does not actually need \ at the beginning of the classpath (leading backslash). Let’s enforce it by static tests to prevent appearing such cases in future _Originally posted...

ihor-sviziev

No plugins in `\Magento\Framework` namespace

1

### Rule Based on https://github.com/magento/magento2/issues/27962: \Magento\Framework cannot have plugins ### Reason ### Implementation

lbajsarowicz

PSR-12 update

5

Now that PSR12 has been ~~released~~ accepted, when will we see an update to include it as part of the ruleset? https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Standards/PSR12/ruleset.xml ToDo list: - [ ] Open PR to...

ghost

Migrate Magento PHMD ruleset

1

### Rule Same rules as https://github.com/magento/magento2/blob/2.3.4/dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml ### Reason Running phpmd without requiring a full installation of Magento makes it easier to run the mess detection in isolation ### Implementation Provide...

fooman

### Rule **Inheritance from namespace other than `\PHPUnit\...` and the same that module is in is forbidden** ### Reason TLDR: Avoid unnecessary coupling between modules. While working with **Unit Tests**...

lbajsarowicz

[New Rule] Implement sniff for functions PHPDoc formatting

3

### Rule PHPDoc formatting for functions and methods. **Acceptance Criteria:** - Sniff covers described on [DevDocs requirements](https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html): > **Functions and methods should have:** >A short description in case it adds...

lenaorobei

`@magentoAppArea` annotation REQUIRED for Controllers Integration Tests

3

### Rule Integration Test class should contain ```php /** * @magentoAppArea adminhtml */ ``` ### Reason This is required annotation to specify the area code for Controllers. Integration Tests fail...

lbajsarowicz