litghost

Results 134 comments of litghost

So I don't really understand what the original problem was. Can you make a better description for the issue and the solution? Maybe some diagrams?

> Remove logs from the level name in fuzzers/0xx-xxx-xxx/logs We want to keep those logs.

> Bug > > Due to the fact that the there is no write to the CMD register the zero frame is used to overwrite the content of the last...

@tmichalak: I believe the bug is actually located here: https://github.com/SymbiFlow/prjxray/blob/master/lib/include/prjxray/xilinx/configuration.h#L253 This switch statement likely needs to advance "frame_address_register" by 1 frame when the CRC command is recieved. I'll annotate your...

> https://github.com/SymbiFlow/prjxray/pull/1335#issuecomment-634476283 Your more detailed example doesn't change my point. The FAR is clearly advanced when the CRC command is issued, and if the bitread modeled that, no special logic...

Type 2 packets remember the previous register target (e.g. FDRI vs CRC vs CMD), but the FAR register behavior is likely independent of the Type 1/2 behavior.

@mithro I never did get the context for this issue, but #1627 is merged. Can this be closed?

Unknown bits: ``` { unknown_bit = "0042089b_5_19", unknown_segment = "0x00420880", unknown_segbit = "27_179" } { unknown_bit = "0042089b_5_20", unknown_segment = "0x00420880", unknown_segbit = "27_180" } { unknown_bit = "0042089b_5_21", unknown_segment...

> Makefiles do have a remove file on failure option? We need to add `.DELETE_ON_ERROR` to the makefile. @tcal-x, can you please retest your case with `.DELETE_ON_ERROR` in the makefile?