Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

While tokio tracing is the widely adopted in the Rust community, there is another (relatively small) tracing library [minitrace](https://github.com/tikv/minitrace-rust/tree/master) which also provides the [OpenTelemetry integration](https://github.com/tikv/minitrace-rust/tree/master/minitrace-opentelemetry). The decision here is going...

Few thoughts considering the current Rust ecosystem - - OpenTelemetry Rust may not need its own tracing instrumentation API, considering the existing tracing APIs in the Rust community, such as...

Haven't tested this, but I believe the effect of `event_enabled` returning false is localized to the layer where it is implemented, which in this case is [OpenTelemetryTracingBridge](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-appender-tracing/src/layer.rs#L150). It should only...

True, did a quick test by modifying the example by adding a console-layer after otel-bridge layer, and forcing event_enabled to be false for otel-bridge - https://github.com/open-telemetry/opentelemetry-rust/compare/main...lalitb:test-multiple-layers?expand=1. The console-layer is not...

Thanks for the PR. Correct me, this derive attribute conversion would be useful only for the metrics, as we would be using tokio-tracing for logs, and possibly for traces too....

> I mentioned this in other contexts, but I don't think that we, as the tracing project, will do this. I understand why this issue/discussion needs to happen, Thanks for...

Just to summarise my understanding of the existing behavior after this PR: - The global shutdown is now removed for `metrics` and `logs`. And shutdown will happen when - explicitly...

Should we also update the comment in these examples : - https://github.com/open-telemetry/opentelemetry-rust/blob/936c46639aa1521bf49dbffba49bbd9795f8ea58/opentelemetry-appender-tracing/examples/basic.rs#L1 - https://github.com/open-telemetry/opentelemetry-rust/blob/936c46639aa1521bf49dbffba49bbd9795f8ea58/opentelemetry-stdout/examples/basic.rs#L1 Also, you have to sign the CLA for CI to succeed, and enable merging.

@aumetra The [tonic PR](https://github.com/hyperium/tonic/pull/1670) is merged. do you think we can now remove the patch from this PR, and make it ready to review/merge. Edit - Or probably better to...

@aumetra as https://github.com/hyperium/tonic/pull/1740 is merged, can you resolve the conflicts in this PR, and fixing the patch dependency, so that it can be reviewed and merged ?