opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

rename duplicate examples

Open demoray opened this issue 1 year ago • 5 comments
trafficstars

When testing the at the workspace level, there are warnings about duplicate examples which may become a hard error from rust. This PR renames the examples.

❯ cargo test --release
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package
`opentelemetry-appender-tracing v0.3.0 (/HOME/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package `opentelemetry-appender-tracing v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.

Fixes # Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • [ ] CONTRIBUTING guidelines followed
  • [ ] Unit tests added/updated (if applicable)
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [ ] Changes in public API reviewed (if applicable)

demoray avatar Mar 26 '24 16:03 demoray

CLA Missing ID CLA Not Signed

  • :white_check_mark: login: lalitb / name: Lalit Kumar Bhasin (6e4aac1c462530a5f37b170aef6a04f4be43eb33)
  • :x: The email address for the commit (ff0b184db086595650ab9d0eabd6a865987c295a, 4f89c92181d8c70394ca83bb41a15253c455988c) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
  • :x: - login: @demoray / name: Brian Caswell . The commit (2dec5a8bc0cbc68aaf38fbed6eaf66a38f7c81e7) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Should we also update the comment in these examples :

  • https://github.com/open-telemetry/opentelemetry-rust/blob/936c46639aa1521bf49dbffba49bbd9795f8ea58/opentelemetry-appender-tracing/examples/basic.rs#L1
  • https://github.com/open-telemetry/opentelemetry-rust/blob/936c46639aa1521bf49dbffba49bbd9795f8ea58/opentelemetry-stdout/examples/basic.rs#L1

Also, you have to sign the CLA for CI to succeed, and enable merging.

lalitb avatar Mar 27 '24 03:03 lalitb

Should we also update the comment in these examples :

Done

Also, you have to sign the CLA for CI to succeed, and enable merging.

I've submitted a request to our CLA manager through the EasyCLA system.

demoray avatar Mar 29 '24 15:03 demoray

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.9%. Comparing base (278f5c7) to head (2dec5a8). Report is 2 commits behind head on main.

:exclamation: Current head 2dec5a8 differs from pull request most recent head 6e4aac1. Consider uploading reports for the commit 6e4aac1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1645   +/-   ##
=====================================
  Coverage   68.9%   68.9%           
=====================================
  Files        136     136           
  Lines      19429   19429           
=====================================
  Hits       13396   13396           
  Misses      6033    6033           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 15:03 codecov[bot]

Should we also update the comment in these examples :

Done

Also, you have to sign the CLA for CI to succeed, and enable merging.

I've submitted a request to our CLA manager through the EasyCLA system.

@demoray any luck with the CLA signing?

cijothomas avatar May 11 '24 17:05 cijothomas

Closing old, inactive PRs. Feel free to reopen when CLA is signed or make a new PR. Thanks.

cijothomas avatar Jul 31 '24 18:07 cijothomas