Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

updated title accordingly. The problem is, as of now there is no-single owner of the created LogRecord. So, to achieve passing ref/mut-ref, we need to first have an owner of...

Ok, It was much simpler to add a special case to avoid LogData cloning in case of single processor ( I believe that would be the most common use-case). Have...

> In C++, there is no guaranteed integral conversion of std::this_thread::get_id() This is correct, and applicable to both `C++` and `Rust`. The core issue is that there isn't a universally...

> what do thread ids look like in C++/Rust? In C++, thread id is an abstraction over the internal platform-specific representation or implementation of a thread, and it may or...

> Just to clarify, sometimes it will be a string that represents a number, e.g. "140550312396608", and sometimes it will be a string that doesn't represent a number, e.g. "bZUPbvaY4d"?...

Nicely summarised. Another option could be to utilize the existing support of [EventId ](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/logs/event_id.h) in the Log API. So user can provide that during logging: ```cpp EventId event_id(12345); logger->Info(event_id, "HelloWorld!",...

Sorry, I mentioned the table name. It should have been event name. Updated now.

- The API in otel-cpp is header-only and is the most used component (as used for library instrumentation), so binary package is not required. We could distribute a source package...

@trask Is this the correct runner - `otel-linux-arm64`, as it doesn't seem to be available - https://github.com/open-telemetry/opentelemetry-rust/actions/runs/9522286107/job/26251528030?pr=1884

@msiddhu Are you getting this crash during application shutdown? If yes, does doing ForceFlush() before shutdown helps?