Lalit Kumar Bhasin

Results 443 comments of Lalit Kumar Bhasin

I vote for option 2, as there are challenges with other options: - Option 1: Tokio-Tracing is deeply ingrained in the Rust ecosystem with wide adoption across many libraries and...

> We know that the tracing crate is widely used in the community, but so is the opentelemetry SDK, it's hard to necessarily see how many [directly instrument with OpenTelemetry](https://sourcegraph.com/search?q=context%3Aglobal+%22opentelemetry+%3D%22+AND+NOT+%22opentelemetry_sdk+%3D%22+AND+NOT+%22tracing-opentelemetry+%3D%22+file%3ACargo.toml+-repo%3Aopentelemetry-rust+count%3Aall&patternType=keyword&sm=0&groupBy=repo)....

Tagging for more inputs. @hawkw, @davidbarsky, as tokio-tracing maintainers @jtescher as tracing-opentelemetry, and opentelemetry-rust maintainer

> Is the logs one linked anywhere in this issue? Not linked, but it was removed as part of global cleanups in #1691 .

Just to be clear, start-time could be moved up, and end-time/aggregation-time would remain in data point - is it so? https://github.com/open-telemetry/opentelemetry-proto/blob/9d139c87b52669a3e2825b835dd828b57a455a55/opentelemetry/proto/metrics/v1/metrics.proto#L156C1-L157C17 // Data points with the 0 value for TimeUnixNano...

Thanks for the heads up. On hold for now, till the spec and proto are updated. * https://github.com/open-telemetry/opentelemetry-specification/issues/3411 * https://github.com/open-telemetry/opentelemetry-proto/pull/503

As per the log [data model ](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#type-any)- the attribute value can be an array of `Any` values i,e can have heterogenous values. While the Span [attributes ](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#attribute) can only have...

This should be good to close. None of the core exporters support the event_name field as of now.

The depedency is coming from [prometheus ](https://crates.io/crates/prometheus/0.13.3) client: https://github.com/tikv/rust-prometheus/blob/master/proto/proto_model.rs. Switching to[ prometheus-client ](https://crates.io/crates/prometheus-client) should get rid of it.

The prometheus client is not compatible with the latest protobuf version - https://github.com/tikv/rust-prometheus/blob/f49c724df0e123520554664436da68e555593af0/Cargo.toml#L30. So not sure if we can upgrade opentelemetry-prometheus with new protobuf version.