Lalit Kumar Bhasin
Lalit Kumar Bhasin
> I see you've got some further improvements, how's the performance improvement for you ? The additional improvements are with (optionally) using the fast hashing with hashbrown/ahash. Will update the...
> > I see you've got some further improvements, how's the performance improvement for you ? > > The additional improvements are with (optionally) using the fast hashing with hashbrown/ahash....
Also added benchmark results, they are single-threaded, so the changes won't improve those., though we see the improvement with the use of hashbrown/ahash.
As discussed during the community meeting, have added the tests for overflow and concurrent measurement recordings.
Just an update, I am still working on it, particularly to mitigate the challenges around concurrency and atomicity - The main issue is making sure the operations of checking if...
> Let us know if this is ready for another review. If not, we can mark as draft again. Sorry for the delay. Will revisit it now. If it takes...
There have been substantial perf improvements in metrics instrumentation with #1833. Will revisit this PR after logs beta release. Closing this for now to keep the PR list minimal.
Please refer to the documentation here - https://crates.io/crates/opentelemetry-appender-tracing: _A [Log Appender](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/glossary.md#log-appender--bridge) that bridges logs from the [tracing crate](https://tracing.rs/tracing/#events) to OpenTelemetry logs._ So it uses LoggerProvider.
One of the concerns I believe was users needing performance in hot-path without depending on the external runtime. This should be resolved with #1506.
Added this issue in Logs beta release milestone, as it involves deprecating/removing below method from [Logs Bridge API surface](https://github.com/open-telemetry/opentelemetry-rust/blob/0ce6a6dc36229e6cdfaf64d01ab19810da387506/opentelemetry/src/logs/logger.rs#L116): ``rust fn library_logger(&self, library: Arc) -> Self::Logger; ``