l0rinc

We're making progress, https://github.com/bitcoin/bitcoin/pull/31144 was just merged! 🎉 The next ones that need some love are: - https://github.com/bitcoin/bitcoin/pull/32827 - https://github.com/bitcoin/bitcoin/pull/32497 - https://github.com/bitcoin/bitcoin/pull/32279

Thanks for reviewing and reproducing https://github.com/bitcoin/bitcoin/pull/32279 - it's also merged 🎉 * https://github.com/bitcoin/bitcoin/pull/32497 * https://github.com/bitcoin/bitcoin/pull/30442 Reviews and ACKs for the above 2 remaining ones would be very welcome.

The big ones are merged, thanks for your help. These are smaller ones - at least from an IBD perspective -, but both are quite simple. Edit: rebased https://github.com/bitcoin/bitcoin/pull/31645 which...

Thanks @pstratem, I did almost exactly the same, the main problem is indeed the loop in https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3498, probably bounded by `BLOCK_DOWNLOAD_WINDOW` - hence the ~1000 worst cases. I have a...

I have compared [v29.1rc1](https://github.com/bitcoin/bitcoin/commit/565af03c37d8262632543a078b2d8d29459d0b91) with the latest [master](https://github.com/bitcoin/bitcoin/commit/dadf15f88cbad37538d85415ae5da12d4f0f1721) branch containing these optimizations: - https://github.com/bitcoin/bitcoin/pull/31490 - https://github.com/bitcoin/bitcoin/pull/31551 - https://github.com/bitcoin/bitcoin/pull/32487 - https://github.com/bitcoin/bitcoin/pull/31144 - https://github.com/bitcoin/bitcoin/pull/32827 - https://github.com/bitcoin/bitcoin/pull/32279 Both branches still have `defaultAssumeValid` of...

I have measured the performance of V30 with previous releases (same dbcache, same assumevalid) - on an Intel i9 with an NVMe SSD and an Intel i7 with a HDD....

You could rebase your change before the fix reverted in https://github.com/bitcoin/bitcoin/pull/32302 to make it green

I can confirm that this fixes the periodic flushes for `-reindex-chainstate`: Details ``` cat debug-7fc8d7f9c1f0fe3795b397327e38465ee6f76b83-1746277780.log | grep FlushStateToDisk 2025-05-03T14:14:56Z [coindb] FlushStateToDisk write: flush mode=PERIODIC, prune=0, cache_large=0, cache_critical=0, periodic=1 2025-05-03T15:16:31Z [coindb]...

You didn't mean to close it, right? ------ I can confirm that this change retains the flushing behavior during IBD as well as far as I can tell from the...

Finished measuring `reindex-chainstate` performance for max dbcache (best case scenario), where this PR shines most (i.e. to avoid the worst-case scenario of doing everything in-memory and crashing at the end...