Results 262 comments of l0rinc

Code review re-ACK 9adf381d810f11b997ea036da6e2ce7dbad74cf6 Someone else with more experience should also review it, I have only lightly tested it locally.

Code review reACK 6bf4f4a87889b0679c744b0a171c98a9386fe8c0 Rebased without other changes since last ACK

reACK a1df8547ca0711d99f05d1b31bc758a8068ba512 It's quite a heavy refactor, I did my best to review all the changes. Someone else should also review it to be sure. The latest https://corecheck.dev/bitcoin/bitcoin/pulls/31713 Sonar warnings...

> I still see the dup library warning on building I don't expect that to be resolved anytime soon, but at least we've [workarounded™ it](https://github.com/hebasto/bitcoin/pull/316/files#diff-7ff2e1d1ed59fa96766a663236d71bfdd00b4af3321fde39f7dbf022bd968a0aR153) for fuzzing on mac (was...

moved to https://github.com/bitcoin/bitcoin/pull/30733

Moved to https://github.com/bitcoin/bitcoin/pull/30734

> Please rebase. The staging branch has been just updated in #318. done

Compiling the same code with different flags

I'm not exactly sure what you're referring to. This fixed my observation about https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1711409392 where adding the -no_warn_duplicate_libraries flag in the source code only fixed fuzzing after I manually deleted...

> unless they are working on the build system itself Yes, that's what happened to me, hence this PR. I have also opened https://gitlab.kitware.com/cmake/cmake/-/issues/26207, though I still think the issue...