l0rinc

Thanks a lot for your help @tdb3, appreciate your reviews and verifications!

ACK fa1bc7c88bb720f02955dbe4e2a174b5a52f3af8

Thanks for checking @fanquake! As the profiler showed, this is only 5% of `AssembleBlock`, and the benchmark varied a lot on my machine as well, it might be why you...

Thanks for the compiler hints @fanquake, I had a lot of problems with MacOSX14.sdk, so was using `Apple clang version 15.0.0 (clang-1500.3.9.4)`. Might give GCC and libstdc++ another try if...

> your time might be better spent reviewing Pull Requests like https://github.com/bitcoin/bitcoin/pull/28280 Thanks for the hint @fanquake, it's a tough PR, I have added my two sats to it: https://github.com/bitcoin/bitcoin/pull/28280#pullrequestreview-2138727793

Thanks for the review @andrewtoth. I'm not sure I see the advantage of inverting the `if (inserted) {` call, just to have two `return it;` calls after. But I did...

Thanks for the review @andrewtoth and @luke-jr! > I think you should benchmark `bitcoind -reindex-chainstate -stopatheight=820000` I don't have that much space yet, but ran it with: ```bash sudo hyperfine...

Thanks a lot for checking, @andrewtoth!

Rebased after https://github.com/bitcoin/bitcoin/pull/28280

> leave a comment with the log to any CI failure I think they meant the [p2p_1p1c_network](https://github.com/bitcoin/bitcoin/pull/31701) failure at https://github.com/bitcoin/bitcoin/actions/runs/12917231673/job/36023158007?pr=31713