Dzmitry Malyshau

Results 953 comments of Dzmitry Malyshau

You are right, we need that updated!

Thank you for making this PR! I honestly haven't worked with JSON schemas in Rust. And I don't know what the established conventions are, so it's hard to tell if...

What are the stability guarantees for `schemars`? Would it work if the struct has fields serialized by different versions of this crate?

Optimally, I'd like to have the normalization property enforced by the type system, like `nalgebra` does. In this case we'd have the `axis` parameter with type `NormalizedVector3` or something.

We need to make sure that `rkyv` feature is tested on CI before merging.

I think an example would be useful here. What kind of stuff you'd be fine graining the trait bounds for?

Thank you for providing the detailed examples! I agree, this would be a welcome feature.

You can do `Basis3::one()` or `Basis3::from_quaternion(Quaternion::one())`

Yes, well, it's just that cgmath has a `One` trait that it tries to use everywhere.. It could have an alias method named `identity` in the basis3

Did you see https://github.com/rustgd/cgmath/pull/508 that is deprecating `look_at`?