Dzmitry Malyshau
Dzmitry Malyshau
These methods are already there, see https://docs.rs/cgmath/0.17.0/cgmath/struct.Vector4.html#impl-AsRef%3C%5BS%3B%204%5D%3E
@vjackson725 so you are suggesting `bytemuck` as an optional dependency? I suppose it could be seen similarly to how `cgmath` optionally supports `mint`. Both `mint` and `bytemuck` are ways to...
You can have a default implementation for `transform_vector`, based on the `transform_point` one. I don't think that building traits on top just to have more constructors is an elegant solution....
Also notice that rotation/transform API uses the full `vector` suffix, unlike the subject methods: - `rotate_vector` - `transform_vector` - `between_vectors` So leaving `to_vec` and `from_vec` means inconsistency in the API.
Slerp is begging for some tests
Unblocking, this should be quite possible now. Not sure though if tuples are really needed as long as we have constructors like `vec3(x,y,z)` or `mat2(vx, vy)`.
Why is `Vector4` so important exactly? Overall, I'm all for it. Great :+1: ! Having `nalgebra` as a strict mathematical alternative, I see `cgmath` story as being more close to...
First off, the serialization is straightforward - just follow the same logic as `Debug` implementation does. > I think it becomes tricky once you're dealing with combined flags For deserialization,...
@torkleyy > I wouldn't call it straightforward though. It doesn't matter, really, if this one is not straightforward. My point is - the code is already there, we just need...
I've implemented the requested logic in a wrapper macro: https://github.com/kvark/bitflags-serial Any feedback is appreciated! If you'd like to move the code into `bitflags` (behind `serde` as a feature), I'd be...