Kevin Boos
Kevin Boos
> The logic I'm thinking of running with is that whenever there's a new message and the user isn't at the bottom, an indicator should be shown. When jtb is...
sorry, so should I go ahead and review/merge this in, or am I waiting for more changes from you or from a different PR first?
thanks for the review comments everyone! Sorry for the delay, I've been working hard on preparing Robrix for a conference talk in 10 days so I'm behind on reviews.
@smarizvi110 can you resolve the conflicts? ping me for a review afterwards. thanks!
Hi @smarizvi110, apologies for the lengthy delay in my review, was attending a conference and then had some travel, and got sick twice. 😑 I think the scope of this...
My previous comment was basically saying that this PR should completely skip trying to deal with the unread message count (which I don't think the other PR has perfectly nailed...
In order to sort things out a bit (as this PR and #206 are in a bit of a messy state), I have implemented this directly in #247, which required...
No problem at all, don't worry about it! I just wanted to go ahead and close this issue since some other folks were also debating about how to deal with...
Thanks, we're discussing it with the Makepad team. Others have confirmed this problem too.
Also, when you submit a PR, please give it a good, descriptive title and description. What i'd like to see different for this PR specifically: 1. A full title, such...