Kevin Boos
Kevin Boos
Please apply the suggested changes in this PR, in particular the `RoomName` type redesign. I've already spent a long time reviewing this PR in detail, and I don't think it's...
> Questions for reviewers: > > 1. For serialization compatibility, is the fallback-and-convert approach acceptable, or would you rather keep the original { room_id, room_name } on disk even though...
> This UPDATE can be digested in three buckets: > ... Thanks for the excellent summary. I agree with all of these design changes; I'm starting a final review now.
I just spent a few hours trying to figure out why ignore lists were seemingly wrong after calling `ignore()` or `unignore()` for a given user ID, even though the actual...
> But when unignoring a user, we don't quite have a choice, because we don't which rooms may include events from the unignored user, only the server may tell us...
> using back-pagination oh that's a clever idea! Thanks, I didn't think about using pagination; I'll give it a shot.
update: it works well, thanks @bnjbvr! Note that I'd still be interested in helping to fix this issue within the SDK itself; I'm just not sure where to begin.