Kevin Boos
Kevin Boos
> There is SignalToUi for enqueue_avatar_update already, so I don't think I can optimize it further. Hmm, ok. Yeah, the only potential cause I could think of was a missing...
Oh, and also feel free to ignore the positioning of the Message action bar (the small Reply button that pops up when you hover over a message). I am in...
Thanks, yes this is a known problem and is due to makepad's lack of support for proper sliding panels from the bottom. Sounds like the same issue as what you...
thanks for the review, I generally agree with @joulei's comments. @tyreseluo let me know when you're ready for another review.
Marking as blocked-on-makepad because most, if not all of this PR's content should be upstreamed into Makepad itself.
> Yeah, it is my serious mistake, No worries, it's not a "serious" mistake haha, it just makes it hard to review. Since I'm short on time these days, I'm...
> @kevinaboos Thanks for your review. > > Also, if it is OK, i want to rebase all the commits' messages to one in this pr and force push, then...
If you want me to squash the PR history down to one commit, I can do that automatically via github's merge process. You don't need to do it manually. But...
Thanks, I wasn't sure if you were ready for me to review this but I left a few comments anyway. Regarding clean encapsulation of the JTB button handling code, yes,...
> Whew, thank you for the review actually! I'll try to figure this thing out. Apologies for the delays, just a bit difficult to work on this amongst other things...