Kevin Boos
Kevin Boos
And, another more major problem, the dock itself seems to transition into an incorrect state. Take a look at the screen recording here... the dock seems to lose a lot...
@alanpoon i apparently forgot to push a commit i made yesterday that restored the `all_known_rooms_loaded` boolean, sorry about that. I have just pushed it now as 0c022f7.
@alanpoon is this blocked on https://github.com/makepad/makepad/pull/711?
is this PR ready? I saw that the Makepad feature that was blocking this has now been merged in, and Robrix's `main` branch now depends on the latest `dev` branch...
also, don't forget to resolve conflicts, quite a few PRs have landed latetly.
I chatted with Rik about this, and he thinks that everything we need _should_ actually be available in both the Shutdown event and the `Startup` event. Take a look at...
> Waiting for Makepad to merge in api requirement for persistent storage and restoration of window_state [makepad/makepad#770](https://github.com/makepad/makepad/pull/770) It's been merged now.
I've also noticed that the window position is not always respected by macOS, but the window size is used properly. Nothing we can do there, as it seems to be...
Friendly reminder to actually _test_ your code before requesting a review. Looks like you forgot to clear the `restore_status_label` in the InviteScreen once it has been restored. It also needs...
Agreed. As I mentioned separately, let's go ahead and collect all of the unnecessary redraws into a single tracking issue (we can use this one) and add checkboxes for each...