Kevin Boos

Results 327 comments of Kevin Boos

For more info about the motivation behind this changeset, here's an example. Assume we start with this original code, which is std-only: ```rust let mut my_map = indexmap::IndexMap::new(); ``` ##...

I see, thanks for the detailed response! I'm definitely keen to consider your concerns and make any requested changes; for ex, a newtype/wrapper struct is totally fine with me. The...

Thanks for the reply again! I'd like to understand things in detail so I can help with any required changes, but I also don't want to waste your time. So...

@bluss thanks for the response! > can't it still be a problem if a crate is written using indexmap and nostd, and then it has its environment shifted by someone...

Thanks for the clarification! I'm more than happy to make the change to enclose hashbrown's `DefaultHashBuilder` in a newtype wrapper.

> Yes, but the other question is the harder problem to crack. Agreed. Thanks for all the excellent feedback and clarifications regarding this std detection issue. In the interim, while...

> That unfortunately does not change the situation in formal terms since either the std feature or your new feature is non-additive after that. Hmm, ok. I suppose this'll have...

No problem, and thanks for your kind words.

> FYI, the master branch is now on `2.0.0-pre`, so this is the time to make any changes. I already moved to explicit `"std"` only, but otherwise the default `S`...

Looks like we can just add a `.no.GNU-stack` marker section to indicate to the linker that our stack isn't executable. Does that fix the issue on your end? Also, did...