project-robius
Populate the dedicated view of direct messages
“People” should be placed above “Room” to better maintain consistency with user habits from Element.
If the is_direct status of a room changes for some reason (for example, if member changes cause the SDK’s is_direct() return value to change, or if the m.direct tag is modified), the current update_room logic does not seem to detect this specific change and send a dedicated update to RoomsList to adjust the grouping of that room.
Let's fix it in the future pr.
“People” should be placed above “Room” to better maintain consistency with user habits from Element.
Fixed.
Thanks, but there are hundreds of irrelevant formatting changes in this PR, making it difficult for me to properly review.
Please undo all of the auto-formatting changes and then re-request a review from me. Unfortunately I no longer have time to try to filter out the salient changes myself, so I will only be reviewing PRs that adhere to these guidelines.
In the future, please first do a self-review of your own code to ensure that all of the changes in the PR are relevant to the specific topic of this PR, and that there are no irrelevant changes.
Yeah, it is my serious mistake, (rustfmt.toml is already existed, but it still cannot control rustfmt's behavior, i use zed editor.)
Reverted now.
Yeah, it is my serious mistake,
No worries, it's not a "serious" mistake haha, it just makes it hard to review. Since I'm short on time these days, I'm unable to review PRs with thousands of irrelevant changes.
Reverted now.
Thanks, appreciate it! In the future we will instate proper formatting rules, which should help with this, at least partially.
@kevinaboos Thanks for your review.
Also, if it is OK, i want to rebase all the commits' messages to one in this pr and force push, then it could be merge safely.
@kevinaboos Thanks for your review.
Also, if it is OK, i want to rebase all the commits' messages to one in this pr and force push, then it could be merge safely.
No, please do not ever force push to any branch once you have made that branch public. It will remove all of the github PR comments.
If you want me to squash the PR history down to one commit, I can do that automatically via github's merge process. You don't need to do it manually.
But in general, no force pushes unless it is a private branch that nobody else has ever seen/reviewed.