Josh Goebel

Results 1720 comments of Josh Goebel

A simple build against our ESM CDN builds (and cdn_release) with rollup should work just fine: (just built from `main`) ``` ❯ ./tools/build.js -t cdn Starting build. Finished build. Writing...

> 4 import hljs from '@highlightjs/cdn-assets/highlight.js'; Probably not what you want, the `es` modules are in the `es` folder. Top-level is CJS.

And using the Node ESM build: ``` ❯ ./tools/build.js -t node Starting build. Finished build. Writing styles. Writing package.json. Writing languages. ................................................................................................................................................................................................... Writing highlight.js ❯ rollup -c test/builds/rollup_import_node_build_esm.mjs test/builds/node_build_as_esm.mjs →...

Closing this until someone can create a PR with an actual broken build (like the several i just committed that all work).

See `test/builds/cdn_build_as_esm.mjs`... it works, as shown above. I'm using relative paths from the source to the library, I don't know how to make npm or your named aliases stuff work,...

> typescript project Oh sorry - I have no idea how to use this a part of a typescript project... some typescript wizard might need to help us with that....

The existing behavior is intentional. https://github.com/highlightjs/highlight.js/issues/3288 Regex is really hard to deal with without a full context-aware parser. I'll leave this open a bit to see if anyone wants to...

@truffle are you still actively maintaining?

@haltman-at are you still actively maintaining?