Josh Goebel

Results 1686 comments of Josh Goebel
trafficstars

If you believe you have test cases that my PR doesn't solve, just point me to them and I'll take another look.

@mohit-nagaraj ping. Could you test my fix against your test cases?

I believe this is closed by https://github.com/highlightjs/highlight.js/pull/4142

> It is better to drop support for CommonJS Version 12 plans to do this, but it's a big change (along with other changes) and I don't have much free...

- Have you absolutely, for certain loaded/bundled the `java` grammar? - Are there any errors in the console?

If you can reproduce with a jsfiddle or similar I can take a look... right now best guess is you haven't built in `java`.

I'm not sure I follow what is being asked for here or what API method is requesting be changed. Source example or before/after mockups might help illustrate the idea.

> This function will draw text to the screen using the foreground spritesheet as the font. Except the font is already *potentially* 16 colors... because each letter if a full...

YAML is the worst. :) What are the valid rules for multi-line strings anyways? Is there some chance we could do this better with our own parser rather than a...