Josh Goebel
Josh Goebel
I think we'd be open to a simple patch to NOT highlight identifiers `Upper_Snake_Works`. This is no type of idiomatic JS I've ever seen. If you have a pointer to...
> for this non idiomatic JS. Exactly. We don't care much about highlighting non idiomatic JS "correctly" or that we poorly highlight non idiomatic JS. We're solving for the most...
Closing as #wontfix. We will highlight idiomatic PascalCase class name only.
I can't tell what if anything you changed in the README, please revert all the unnecessary linting/spacing changes. The other changes for the base16 styles seem to be correct. I'm...
> You want me to add a new revert commit? That'd be great.
Actually we may need more work here, but I'm not sure what to suggest. It just clicked that these are actually assets copied directly from [another build system](https://github.com/highlightjs/base16-highlightjs). So modifying...
See last comment. Closing this. I feel like a tiny improvement to clean this up inside our CSS processing pipeline would be a different PR entirely - not a reuse...
How are you generating the expect file? All literal quotes need to be HTML escaped.
Every `"` should be `"` as the failing test is telling you. The output from Highlight.js must be HTML encoded.
#4105 has solved this slightly more flexibly. Sorry.