Josh Goebel

Results 1643 comments of Josh Goebel
trafficstars

Ruby 3.2.something: ``` # 100mb of repeated "A"s > bad_input="/super/man/#{"A"*100000000}/lives"; nil => nil [14] pry(main)> Benchmark.measure { bad_input.match(/[A-Z]+[^A-Z]/) }.real => 0.8092678760003764 ``` Seems plenty fast to me...

Oh CodeQL did say the problem was much improved with Ruby 3.2, let me try 3.1... ``` > bad_input="/super/man/#{"A"*100000000}/lives"; nil => nil irb(main):007> RUBY_VERSION => "3.1.2" irb(main):008> Benchmark.measure { bad_input.match(/[A-Z]+[^A-Z]/);...

Please do the "upgrade" work in an isolated commit (that doesn't move the file around) so I can properly review the changes.