highlightjs-solidity icon indicating copy to clipboard operation
highlightjs-solidity copied to clipboard

Published 20 hours ago • verified publisher icon highlightjs

Support highlight.js v11?

Open wongzigii opened this issue 10 months ago • 6 comments

Is there any plan to support highlight.js v11?

wongzigii avatar Jan 24 '25 18:01 wongzigii

@truffle are you still actively maintaining?

joshgoebel avatar Jan 25 '25 03:01 joshgoebel

@haltman-at are you still actively maintaining?

joshgoebel avatar Jan 25 '25 03:01 joshgoebel

Hi! Unfortunately, not really. The Truffle project that had taken over maintenance of this repo (and corresponding NPM package) has since ceased operation, and I no longer even work for Consensys. I can perhaps do some maintenance in my free time -- I haven't bothered updating it for newer versions of Solidity, that would be pretty easy -- but updating for a new highlight.js version is likely beyond what I'm willing to take on right now. I dunno, anyone else want to take it on?

haltman-at avatar Jan 27 '25 06:01 haltman-at

Since this is depended on "highlightjs": "^9.12.0", I can help to maintain this to support v11. Is there any guideline i can start with? @joshgoebel

wongzigii avatar Jan 27 '25 16:01 wongzigii

Can we skip v10 and directly migrate to v11?

wongzigii avatar Jan 27 '25 16:01 wongzigii

Oh hm -- I'm not sure what my permissions on this repo actually are. I appear to still have merge permissions, for instance, but it doesn't look like I can add new maintainers or anything. I have no idea who would have that permission atm...

haltman-at avatar Jan 28 '25 01:01 haltman-at

I was able to update highlight-solidity to highlight.js@11 here.

It didn't actually require any significant changes to make it work.

Do you still happen to have rights to publish npm package? Maybe we could get some movement to add that support. We actually downgraded to highlight.js@10 to make it work with highlight-solidity 😆

Sekhmet avatar Nov 19 '25 22:11 Sekhmet