Josh Goebel

Results 1642 comments of Josh Goebel
trafficstars

I'm fine doing this work and making a PR, I just want to know the work is blessed so I'm not wasting my time.

Moved my unrelated comments into #51.

> but I worry that will add to the problem since the extra parent class has to have its constructors called, etc. Don't understand this concern. C++ makes this pretty...

> Overall though you do want to be careful of the target and priorities for the GFX library. It's meant to be general and easy to use and maintain which...

Can you provide a link to the sketch you're using for testing? It's probably just the chain of constructors though now that I think about it. I think you could...

@PaintYourDragon Yeah, it's just crappy how for the most part the linker can remove unnecessary functions but the it all falls apart for virtual. There is no reason a nice...

A lot of our graphics primitives are just copies from GFX, so I was trying to find some way to easily reuse that code (without having to copy it and...

Should work, are you seeing an error in console? Are you loading a CSS theme? What makes you think it's not working?

And could we perhaps get a new release that's not broken?

Ping. Anyway any of us could help get a fix out for this?