Josh Goebel

Results 1726 comments of Josh Goebel

> The problem with the mapping table it that it completely hides the fact that there is more information than "colour -> number": the position of said colour. OK... How...

I'd suggest two tables... one dealing with the mapping to color and a second making it clear the colors/numbers are sequential. Isn't that often exactly how you see this done...

> UnknownWord error, just as if an immediate referenced a function that's not been defined yet. Perhaps that's worth a test also? I don't think that's in there now... I...

For example it seems clear to me that a test like this would make sense: ``` - create 700,000 new robots from the factory - turn on 676,000 - they...

> so a right implementation should handle the case were there is no more name to give, to avoid bad things; I definitely think a test should be required for...

My language knowledge may not be broad enough but every `map` implementation I've used does NOT mutate the input - nor would I expect it to, it provides a copy......

Sure you can use `map` to mutate, just pointing out that's not it's standard behavior - at least in languages I'm familiar with.

> and there probably are tracks where mutation is expected. ... that I can send a pull request for both ways and leave it up to track maintainers I hadn't...

Please also include the `dist` folder (see 3rd party contributor docs) so users have a standard CJS/auto-register version of the grammar they can drop in if they are still using...

Closing for inactivity. When `dist` is available on the public repo please re-open and we can get this merged.