Josh Lubaway
Josh Lubaway
Cool extension! I just made a plugin to add back the Octocats to the empty notifications page on GitHub since they recently removed them https://gist.github.com/jish/446f0d91e1339e7aba07 But I agree `console.log` would...
Ah, yes. That seems correct. It appears that accessing local storage causes an error. No error appears to be thrown when attempting to set a cookie: ```js document.cookie = "foo=bar";...
I guess we've always just hard coded an order in the past. I'm ok with changing the order for everyone and / or making the order configurable. Josh > On...
Yea, I agree. The PHP and Go checks seem like good candidates for plugins.
@mpapis I changed the access controls on `pre-commit-plugins`, can you check if you have more permission now? https://github.com/pre-commit-plugins/pre-commit-php
try now? :x
Yea, definitely :)
@leonsp this change generally looks good, could you remove the version bump, and atttempt to fix the tests.
@mpapis Do you have ideas on how should it be structured?
That is likely coming from one of the JavaScript checks. If you're doing solely PHP development you can disable the Rails checks: ``` $ pre-commit disable git checks rails ```...