pre-commit icon indicating copy to clipboard operation
pre-commit copied to clipboard

Choosing order of checks?

Open knovoselic opened this issue 10 years ago • 4 comments

Is there a way to define order in which checks are executed? For example, I'd like to run to run ci check (pre_commit:ci rake task) last because it takes the longest.

knovoselic avatar Apr 02 '15 11:04 knovoselic

try with https://github.com/jish/pre-commit#enabling--disabling-checks--warnings

mpapis avatar Apr 02 '15 11:04 mpapis

I'm using YAML for configuration (config/pre_commit.yml) and ci is last in checks_add array, but it still gets executed first (or at least before rubocop). Am I missing something?

knovoselic avatar Apr 02 '15 11:04 knovoselic

@jish it's a bug or feature request?

mpapis avatar Apr 02 '15 11:04 mpapis

I guess we've always just hard coded an order in the past.

I'm ok with changing the order for everyone and / or making the order configurable.

Josh

On Apr 2, 2015, at 04:58, Michal Papis [email protected] wrote:

@jish it's a bug or feature request?

— Reply to this email directly or view it on GitHub.

jish avatar Apr 02 '15 15:04 jish