pre-commit icon indicating copy to clipboard operation
pre-commit copied to clipboard

Reek checker plugin to detect ruby code smells

Open leonsp opened this issue 11 years ago • 7 comments

Adds a reek check plugin. Reek is a static code analysis gem for Ruby. Unlike Rubocop, it doesn't do style, but catches several bad practices Rubocop misses.

leonsp avatar Aug 21 '14 16:08 leonsp

@jish it would be great opportunity to make use of pre-commit-plugins

mpapis avatar Aug 21 '14 17:08 mpapis

@leonsp this change generally looks good, could you remove the version bump, and atttempt to fix the tests.

jish avatar Aug 21 '14 18:08 jish

@mpapis Do you have ideas on how should it be structured?

jish avatar Aug 21 '14 18:08 jish

extracting this to separate gem is mostly creating the same files / directories as in this PR, an extra readme, gemspec and few test files would be needed

mpapis avatar Aug 21 '14 18:08 mpapis

@leonsp please have a look into https://github.com/mpapis/pre-commit-php as an example how to create external plugins

mpapis avatar Sep 13 '14 20:09 mpapis

Thanks! I will try to set up something similar (pre-commit-reek, etc).

leonsp avatar Sep 14 '14 18:09 leonsp

now on master you can:

pre-commit new plugin-name 'Author Name' author@email 'description of the plugin'

this will generate scaffold for your gem - should be easy to move it from this point on, please let me know if you find any more instructions that should be added (open a new issue).

mpapis avatar Feb 20 '16 11:02 mpapis