pre-commit icon indicating copy to clipboard operation
pre-commit copied to clipboard

migrate plugins to new repositories

Open mpapis opened this issue 11 years ago • 15 comments

follow up for #152, as we have https://github.com/pre-commit-plugins we should consider separating plugins to separate repositories.

@jish I would start with checks that do not have any dependencies and are not included by default .. did not had time to look which ones fit best

mpapis avatar Sep 04 '14 18:09 mpapis

something like #164 would be a good point to start, @jish?

mpapis avatar Sep 06 '14 01:09 mpapis

Yea, I agree. The PHP and Go checks seem like good candidates for plugins.

jish avatar Sep 06 '14 20:09 jish

@jish in https://github.com/pre-commit-plugins I get You don't appear to have permission to create repositories for this organization. Sorry about that.

mpapis avatar Sep 12 '14 14:09 mpapis

and I can not transfer rights of https://github.com/mpapis/pre-commit-php because of You don't have admin rights to pre-commit-plugins

mpapis avatar Sep 13 '14 13:09 mpapis

@mpapis I changed the access controls on pre-commit-plugins, can you check if you have more permission now?

https://github.com/pre-commit-plugins/pre-commit-php

jish avatar Oct 01 '14 21:10 jish

can not push to the new repo:

ERROR: Permission to pre-commit-plugins/pre-commit-php.git denied to mpapis. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

mpapis avatar Oct 01 '14 21:10 mpapis

go to https://github.com/orgs/pre-commit-plugins/teams and add the new repo to core team - or add me to Owners/admins

mpapis avatar Oct 01 '14 21:10 mpapis

try now? :x

jish avatar Oct 01 '14 22:10 jish

it worked :)

mpapis avatar Oct 01 '14 22:10 mpapis

and the gem is here https://rubygems.org/gems/pre-commit-php

mpapis avatar Oct 01 '14 22:10 mpapis

and all the badges are online => https://github.com/pre-commit-plugins/pre-commit-php#readme

mpapis avatar Oct 01 '14 22:10 mpapis

and @jish can push the gem now too: http://rubygems.org/gems/pre-commit-php

mpapis avatar Oct 01 '14 22:10 mpapis

and #180 is merged, the php plugin will work now outside of the pre-commit gem - it's a good start :)

mpapis avatar Oct 21 '14 01:10 mpapis

@jish I would say this is one of the steps towards 1.0.0 what do you think?

mpapis avatar Jan 07 '15 11:01 mpapis

Yea, definitely :)

jish avatar Jan 07 '15 18:01 jish